Don't return Pending node when fork choice reverts to justified block - #9962
Merged
mergify[bot] merged 2 commits intoSep 9, 2026
Merged
Conversation
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
michaelsproul
changed the title
michaelsproul
approved these changes
Sep 9, 2026
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks.
We likely need this for fork choice compliance tests, and I've run into it while fuzzing block production.
michaelsproul
changed the title
|
Queued — the merge queue status continues in this comment ↓. |
michaelsproul
added
consensus
Merge Queue Status
This pull request spent 31 minutes 59 seconds in the queue, including 28 minutes 3 seconds running CI. Required conditions to merge
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9544.
Description
find_head_walkwas filtering virtual EMPTY/FULL children of a PENDING node againstviable_nodes. Under deep non-finality the justified seed can be non-viable, so those children were dropped andget_headreturned Pending, which breaks block production.pending_head_resolves_when_justified_subtree_non_viableingloas_payload.rs.